Pipelines: exclude in-repo .ps1 scripts from CodeSign post-analysis#40541
Merged
benhillis merged 1 commit intoMay 15, 2026
Merged
Conversation
benhillis
force-pushed
the
ben/sdl-codesign-ps1-exclude-pr
branch
from
84b4535 to
e019c7d
Compare
Member
Author
|
This should fix the pipeline issue we've been seeing, I'm running a private release build to see. |
benhillis
force-pushed
the
ben/sdl-codesign-ps1-exclude-pr
branch
2 times, most recently
from
90f52f1 to
a01c6f2
Compare
The Guardian CodeSign tool was scanning all .ps1 files in the source tree and failing the release build on diagnostic / dev / test helper scripts that aren't shipped (the OneBranch codesign targetGlob already restricts signing to .dll/.exe/.sys/.msi/.msix/.appx/.nupkg). Set ob_sdl_codeSignValidation_excludes to skip **\*.ps1 at the pipeline level for the release, nightly, and PR OneBranch pipelines, and combine with the existing testbin\** exclude in build-job.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
force-pushed
the
ben/sdl-codesign-ps1-exclude-pr
branch
from
a01c6f2 to
e33c0b8
Compare
OneBlue
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Guardian CodeSign post-analysis task has been failing the release build on
.ps1files in the source tree (diagnostic / dev / test helpers) that we don't ship. The OneBranchtargetGlobfor actual signing already restricts signing to.dll/.exe/.sys/.msi/.msix/.appx/.nupkg, so PowerShell scripts being flagged here is purely a CodeSign validation noise issue.Change
Set
ob_sdl_codeSignValidation_excludesto skip**\*.ps1on the three OneBranch pipelines (release, nightly, PR), and combine with the existingtestbin\**exclusion inbuild-job.ymlso neither rule clobbers the other.Files
.pipelines/build-job.yml— extend existing exclude list with**\*.ps1.pipelines/wsl-build-release-onebranch.yml— add pipeline-level exclude.pipelines/wsl-build-nightly-onebranch.yml— add pipeline-level exclude.pipelines/wsl-build-pr-onebranch.yml— add pipeline-level excludeValidation
Dry-run pipeline (with test+flight stages skipped) is running against the same change on a sibling branch in parallel; opening this PR now to get review going while that finishes.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com