fix: remove svt-av1 and disable svt-av1 in dependents#17272
Open
binujp wants to merge 1 commit into
Open
Conversation
Remove svt-av1 component from the distro — it is not needed and
carries codec licensing considerations.
- Remove svt-av1 from components.toml, publish channels, lock, and
rendered specs
- Add build.without svtav1 to gstreamer1-plugins-bad-free (bcond
defaults ON via %{defined fedora} in AZL build env)
- Create dedicated libavif comp.toml with build.without svt (bcond
defaults ON in non-bootstrap builds)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the svt-av1 component from the Azure Linux distro and prevents dependent components from implicitly enabling SVT-AV1 support (which would otherwise introduce build/runtime deps on SvtAv1Enc / libSvtAv1Enc.so).
Changes:
- Removed
svt-av1from rendered specs, locks, and publish channel lists. - Disabled SVT-AV1-related build conditionals in
gstreamer1-plugins-bad-free(svtav1) andlibavif(svt) viabuild.without, generating corresponding*.azl.macrosto force the bconds off. - Updated rendered specs/locks to reflect the component config changes (including release/changelog bumps).
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/s/svt-av1/svt-av1.spec | Removes rendered spec for the svt-av1 component. |
| specs/s/svt-av1/sources | Removes source hash entry for svt-av1 rendered sources. |
| locks/svt-av1.lock | Removes lock file for the deleted svt-av1 component. |
| base/comps/libavif/libavif.comp.toml | Introduces component config to disable svt bcond (avoids SVT-AV1 dependency). |
| specs/l/libavif/libavif.spec | Rendered spec updated to load generated macros and include Source9999, plus release/changelog bump. |
| specs/l/libavif/libavif.azl.macros | New generated macros file forcing _without_svt. |
| locks/libavif.lock | Updates input fingerprint for the new libavif component config. |
| base/comps/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.comp.toml | Extends build.without to include svtav1 so the SVT-AV1 plugin is not built. |
| specs/g/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.spec | Rendered spec release bump corresponding to config change. |
| specs/g/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.azl.macros | Updates generated macros to force _without_svtav1. |
| locks/gstreamer1-plugins-bad-free.lock | Updates input fingerprint for the gstreamer1-plugins-bad-free config change. |
| base/comps/components.toml | Removes inline entries for libavif (now customized) and svt-av1 (removed). |
| base/comps/components-publish-channels.toml | Removes svt-av1 from publish channel component list. |
Comment on lines
14
to
+18
| [components.gstreamer1-plugins-bad-free] | ||
| build.without = ["extras", "dc1394", "onnx", "openh264"] | ||
| build.without = ["extras", "dc1394", "onnx", "openh264", "svtav1"] | ||
|
|
||
| # AZL does not ship svt-av1 — disable the svtav1 gstreamer plugin. | ||
| # The bcond defaults ON via %{defined fedora} which is true in the AZL build env. |
Comment on lines
+1
to
+4
| # AZL does not ship svt-av1 — disable svt-av1 codec support. | ||
| # The svt bcond defaults ON in non-bootstrap builds. | ||
| [components.libavif] | ||
| build.without = ["svt"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the svt-av1 component from the distro and explicitly disable svt-av1 support in dependent packages.
Changes
svtav1tobuild.without— the%bcond svtav1defaults ON via%{defined fedora}which is true in the AZL build environment, so the plugin was being built and shippinglibgstsvtav1.sowith a dependency onlibSvtAv1Enc.so.3libavif.comp.tomlwithbuild.without = ["svt"]— thesvtbcond defaults ON in non-bootstrap buildsTesting
svtav1to existingbuild.withoutlist using the same pattern as the other disabled bconds)Part of the codec removal effort.