Add supports for generating identity signing key (IDK_S)#828
Open
Add supports for generating identity signing key (IDK_S)#828
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new LVBS VSM call for deriving an identity signing key pair (IDK_S) from the platform root key and returning the public key to VTL0. It extends the LVBS VSM surface, adds supporting error/host plumbing, and brings in the crypto dependencies needed for P-384 key derivation.
Changes:
- Add
GenerateIdentitySigningKeyVSM function ID and dispatcher support. - Implement IDK_S derivation/export logic in
mshv::vsm, plus a unit test for the derivation helper. - Expose PRK retrieval, add new VSM errors, and update dependency/ratchet metadata.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
litebox_platform_lvbs/src/mshv/vsm.rs |
Adds IDK_S derivation, public-key export, dispatcher wiring, and a unit test. |
litebox_platform_lvbs/src/mshv/mod.rs |
Defines the new VSM function ID and enum entry. |
litebox_platform_lvbs/src/mshv/error.rs |
Adds PRK/IDK_S error variants and errno mappings. |
litebox_platform_lvbs/src/host/mod.rs |
Re-exports PRK getter for internal use. |
litebox_platform_lvbs/src/host/lvbs_impl.rs |
Adds PRK getter implementation. |
litebox_platform_lvbs/Cargo.toml |
Adds hkdf and p384 dependencies. |
dev_tests/src/ratchet.rs |
Updates the static-count ratchet for LVBS. |
Cargo.lock |
Locks the newly added crypto dependency graph. |
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds supports for generating identity signing key (IDK_S) to the LVBS platform. A new function,
mshv_vsm_gen_identity_signing_keygenerates an IDK_S key pair based on the platform root key and write the public portion of it to the VTL0-side buffer. Currently, it returns an uncompressed SEC1 P-384 public key (97 bytes).