fix: multiple memcpy calls in image processing funct... in bmms.c#17
Open
orbisai0security wants to merge 1 commit into
Open
fix: multiple memcpy calls in image processing funct... in bmms.c#17orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
src/bmms.c.Vulnerability
V-001src/bmms.c:163Description: Multiple memcpy calls in image processing functions do not validate that the source data fits within the destination allocation. In src/bmms.c:163, the expression
w * h * pd * sizeof*tmpcan overflow if attacker-controlled image dimensions are large, resulting in an undersized allocation followed by a heap buffer overflow. In src/imprintf.c:562-564, exactly 0x100 bytes are copied from bufopt into a 0x100-byte allocation without verifying bufopt is null-terminated or bounded within 0x100 bytes. In src/ransac.c:106-108, the sizesused in memcpy is not validated against the actual allocation sizes of the target buffers.Changes
src/bmms.cVerification
Automated security fix by OrbisAI Security