Add storage description link discovery#1854
Open
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Open
Add storage description link discovery#1854SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Conversation
csarven
reviewed
May 6, 2026
Member
There was a problem hiding this comment.
Great, thanks for doing this. I haven't run the tests but this generally looks good to me. I've run the code locally and it is referring to the expected URL for storage description resource.
Does this code assume that storage root is always at req.hostname + '/'?
I can't remember now but does NSS allow non-root path to be storage root? If so, does the code take that into account?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
storageDescriptionLink headers for GET, HEAD, and OPTIONS requests.Point the relation to the root storage metadata resource (
/.meta).Cover resources and containers in HTTP integration tests.
Fixes #1805.
Tests
npm run lint
npm run mocha-integration