feat: Node.js 26.0.0 (expected May 5, 2026)#2474
feat: Node.js 26.0.0 (expected May 5, 2026)#2474nschonni wants to merge 2 commits intonodejs:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks, I've updated the title to reflect the new date, but haven't updated the JSON till it gets cleared up |
| @@ -1,4 +1,55 @@ | |||
| { | |||
| "26": { | |||
| "start": "2026-04-28", | |||
There was a problem hiding this comment.
Land and rebase locally when the Alpine builds are available on that date
| "start": "2026-04-28", | |
| "start": "2026-05-05", |
There was a problem hiding this comment.
Probably now 2026-05-05 if there are no new holdups.
The May 4 date was a typo/mistake, the correct date is May 5, 2026. The linked comment has been updated to reflect that. |
Fixed in the comment section too :-) We've also developed a fix for the underlying issue (specific to the macos universal binaries included in the .pkg file) so I would expect we will be able to get it out next Tuesday without additional problems 🤞🏻 |
MikeMcC399
left a comment
There was a problem hiding this comment.
Hi @nschonni!
Please check:
docker-node/.github/workflows/build-test.yml
Lines 96 to 97 in 6f8bcd7
This will fail if there is no yarn installed
node:internal/modules/cjs/loader:1478
throw err;
^
Error: Cannot find module '/yarn'
|
https://github.com/nodejs/node/releases/tag/v26.0.0 is now released and should be showing up soon. |
|
And to make it more interesting, https://www.githubstatus.com/ shows GitHub Actions is once again having issues! |
|
Not sure why one of the |
I'll try adding this to the job step |
I saw that also running . |
|
There is currently still content missing on https://nodejs.org/download/release/ https://nodejs.org/download/release/latest-v26.x/ is empty for instance |
21282c3 to
1dcd3ca
Compare
|
I've posted to Slack about the missing release bits and the releasers / website experts are sorting that out. |
|
And whilst all that's been happening https://unofficial-builds.nodejs.org/download/release/v26.0.0 is showing the musl builds. That however is not recognized currently by |
|
I'm marking this as ready, but I'm taking a look Line 118 in 83fecd5 |
MikeMcC399
left a comment
There was a problem hiding this comment.
The build test changes to exclude Yarn tests look good!
A couple of the Dockerfiles had the 26.0 version instead of 26.0.0 in them. I've added change suggestions for these two.
MikeMcC399
left a comment
There was a problem hiding this comment.
All tests are now passing, so from my point of view the PR should be good to go 👍🏻
MikeMcC399
left a comment
There was a problem hiding this comment.
I have to take that back.
There are still Yarn install scripts in there
| && npm --version \ | ||
| && rm -rf /tmp/* | ||
|
|
||
| ENV YARN_VERSION=1.22.22 |
There was a problem hiding this comment.
This shouldn't be in here!
| && npm --version \ | ||
| && rm -rf /tmp/* | ||
|
|
||
| ENV YARN_VERSION=1.22.22 |
Description
Creating a draft PR for the release that was originally expected on the Apr 22nd,
but now appears pushed to the 28th.postponed to May 5, 2026.Fixes #2435
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist