test: stop requiring core.autocrlf=true on windows#63102
Open
nadalaba wants to merge 1 commit intonodejs:mainfrom
Open
test: stop requiring core.autocrlf=true on windows#63102nadalaba wants to merge 1 commit intonodejs:mainfrom
nadalaba wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Note that we explicitly request it to be set to Lines 11 to 12 in f694c3a Can you split this into two PR so this can be reviewed and backported separately? |
Signed-off-by: Nad Alaba <37968805+nadalaba@users.noreply.github.com>
nadalaba
force-pushed
the
fix-windows-tests
branch
from
867cffd to
a0a5162
Compare
nadalaba
changed the title
Author
I opened #63118 for the other test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests on Windows (
test\parallel\test-snapshot-typescript) require the repo to be checked-out with the git configcore.autocrlfset totrue.However, a lot of users prefer to use modern editors that can handle LF and keep core.autocrlf set to false to minimize headaches.
This PR fixes the tests for them without breaking it for others.