Skip to content

build,win: build,win: replace LTCG with Thin LTO for releases #63114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanStojanovic wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −13
Open

build,win: build,win: replace LTCG with Thin LTO for releases #63114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ef499
build,win: replace LTCG with Thin LTO for releases
StefanStojanovic Apr 30, 2026
19b298a
build,win: limit LTO parallelisation for releases
StefanStojanovic May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,13 @@
},
},
},],
['(enable_thin_lto=="true" or enable_lto=="true") and lto_jobs!=""', {
'msvs_settings': {
'VCLinkerTool': {
'AdditionalOptions': ['/opt:lldltojobs=<(lto_jobs)'],
},
},
},],
],
'target_conditions': [
['_toolset=="target"', {
Expand Down
9 changes: 9 additions & 0 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,14 @@
help="Enable compiling with thin lto of a binary. This feature is only available "
"on windows.")

parser.add_argument("--lto-jobs",
action="store",
dest="lto_jobs",
default=None,
help="Set the number of parallel LTO code generation jobs during linking. "
"Defaults to the number of CPU cores. Lower values reduce peak memory "
"usage at the cost of longer link times. Only effective with LTO enabled.")

parser.add_argument("--link-module",
action="append",
dest="linked_module",
Expand Down Expand Up @@ -2001,6 +2009,7 @@ def configure_node(o):

o['variables']['enable_lto'] = b(options.enable_lto)
o['variables']['enable_thin_lto'] = b(options.enable_thin_lto)
o['variables']['lto_jobs'] = options.lto_jobs or ''

if options.node_use_large_pages or options.node_use_large_pages_script_lld:
warn('''The `--use-largepages` and `--use-largepages-script-lld` options
Expand Down
32 changes: 19 additions & 13 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ set target_arch=x64
set ltcg=
set thin_lto=
set lto=
set lto_jobs=
set pgo_generate=
set pgo_use=
set target_env=
Expand Down Expand Up @@ -110,6 +111,7 @@ if /i "%1"=="nonpm" set nonpm=1&goto arg-ok
if /i "%1"=="ltcg" set ltcg=1&goto arg-ok
if /i "%1"=="thin-lto" set thin_lto=1&goto arg-ok
if /i "%1"=="lto" set lto=1&goto arg-ok
if /i "%1"=="lto-jobs" set "lto_jobs=%2"&goto arg-ok-2
if /i "%1"=="pgo-generate" set pgo_generate=1&goto arg-ok
if /i "%1"=="pgo-use" set pgo_use=1&goto arg-ok
if /i "%1"=="v8temporal" set v8temporal=1&goto arg-ok
Expand Down Expand Up @@ -187,6 +189,20 @@ goto next-arg

:args-done

if defined build_release (
set config=Release
set package=1
set msi=1
set licensertf=1
set download_arg="--download=all"
set i18n_arg=full-icu
set projgen=1
set cctest=1
set thin_lto=1
@REM Parallel LTO link jobs can cause OOM issues, so we limit it to 2 by default for release builds in the release CI.
set lto_jobs=2
)

:: LTO mutual exclusion
set lto_count=0
if defined ltcg set /a lto_count+=1
Expand All @@ -208,18 +224,6 @@ if defined pgo_generate if defined pgo_use (
exit /b 1
)

if defined build_release (
set config=Release
set package=1
set msi=1
set licensertf=1
set download_arg="--download=all"
set i18n_arg=full-icu
set projgen=1
set cctest=1
set ltcg=1
)

if defined msi set stage_package=1
if defined package set stage_package=1

Expand All @@ -243,6 +247,7 @@ if defined nonpm set configure_flags=%configure_flags% --without-npm
if defined ltcg set configure_flags=%configure_flags% --with-ltcg
if defined thin_lto set configure_flags=%configure_flags% --enable-thin-lto
if defined lto set configure_flags=%configure_flags% --enable-lto
if defined lto_jobs set configure_flags=%configure_flags% --lto-jobs=%lto_jobs%
if defined pgo_generate set configure_flags=%configure_flags% --enable-pgo-generate
if defined pgo_use set configure_flags=%configure_flags% --enable-pgo-use
if defined release_urlbase set configure_flags=%configure_flags% --release-urlbase=%release_urlbase%
Expand Down Expand Up @@ -908,7 +913,7 @@ set exit_code=1
goto exit

:help
echo vcbuild.bat [debug/release] [msi] [doc] [test/test-all/test-addons/test-doc/test-js-native-api/test-node-api/test-internet/test-tick-processor/test-known-issues/test-node-inspect/test-check-deopts/test-npm/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [build-addons/build-js-native-api-tests/build-node-api-tests/build-ffi-tests] [ignore-flaky] [static/dll] [noprojgen] [projgen] [clang-cl] [ccache path-to-ccache] [small-icu/full-icu/without-intl] [nobuild] [nosnapshot] [nonpm] [ltcg] [thin-lto] [lto] [pgo-generate] [pgo-use] [licensetf] [sign] [x64/arm64] [vs2022/vs2026] [download-all] [enable-vtune] [lint/lint-ci/lint-js/lint-md] [lint-md-build] [format-md] [package] [build-release] [upload] [no-NODE-OPTIONS] [link-module path-to-module] [debug-http2] [debug-nghttp2] [clean] [cctest] [no-cctest] [openssl-no-asm]
echo vcbuild.bat [debug/release] [msi] [doc] [test/test-all/test-addons/test-doc/test-js-native-api/test-node-api/test-internet/test-tick-processor/test-known-issues/test-node-inspect/test-check-deopts/test-npm/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [build-addons/build-js-native-api-tests/build-node-api-tests/build-ffi-tests] [ignore-flaky] [static/dll] [noprojgen] [projgen] [clang-cl] [ccache path-to-ccache] [small-icu/full-icu/without-intl] [nobuild] [nosnapshot] [nonpm] [ltcg] [thin-lto] [lto] [lto-jobs number-of-jobs] [pgo-generate] [pgo-use] [licensetf] [sign] [x64/arm64] [vs2022/vs2026] [download-all] [enable-vtune] [lint/lint-ci/lint-js/lint-md] [lint-md-build] [format-md] [package] [build-release] [upload] [no-NODE-OPTIONS] [link-module path-to-module] [debug-http2] [debug-nghttp2] [clean] [cctest] [no-cctest] [openssl-no-asm]
echo Examples:
echo vcbuild.bat : builds release build
echo vcbuild.bat debug : builds debug build
Expand All @@ -922,6 +927,7 @@ echo vcbuild.bat no-cctest : skip building cctest.exe
echo vcbuild.bat ccache c:\ccache\ : use ccache to speed build
echo vcbuild.bat thin-lto : builds with Thin LTO applied globally to all targets
echo vcbuild.bat lto : builds with Full LTO applied globally to all targets
echo vcbuild.bat thin-lto lto-jobs 2 : builds with Thin LTO applied globally to all targets and limits parallel LTO link jobs (reduces peak memory usage)
echo vcbuild.bat pgo-generate : builds instrumented binary for PGO (profile first, then rebuild with pgo-use)
echo vcbuild.bat pgo-use : builds optimized binary using PGO profile data
goto exit
Expand Down
Loading