Skip to content

[v26.x backport] test: accept OpenSSL 4 generic internal error for DH key-type mismatches #63129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
May 5, 2026
Merged

[v26.x backport] test: accept OpenSSL 4 generic internal error for DH key-type mismatches #63129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions test/parallel/test-crypto-dh-stateless-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,28 @@ const assert = require('assert');
const crypto = require('crypto');
const { hasOpenSSL } = require('../common/crypto');

// Error code for a key-type mismatch during (EC)DH. The underlying OpenSSL
// error code varies by version, and in OpenSSL 4.0 by platform: some builds
// report a generic internal error instead of a typed key-type mismatch.
// https://github.com/openssl/openssl/issues/30895
// TODO(panva): Tighten this check once/if fixed.
let keyTypeMismatchCode;
if (hasOpenSSL(4, 0)) {
keyTypeMismatchCode =
/^ERR_OSSL_EVP_(OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE|INTERNAL_ERROR)$/;
} else if (hasOpenSSL(3)) {
keyTypeMismatchCode = 'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE';
} else {
keyTypeMismatchCode = 'ERR_OSSL_EVP_DIFFERENT_KEY_TYPES';
}

function assertErrorCode(actual, expected) {
if (expected instanceof RegExp)
assert.match(actual, expected);
else
assert.strictEqual(actual, expected);
}

assert.throws(() => crypto.diffieHellman(crypto.generateKeyPairSync('ec', { namedCurve: 'P-256' }), null), {
name: 'TypeError',
code: 'ERR_INVALID_ARG_TYPE',
Expand Down Expand Up @@ -341,16 +363,16 @@ for (const { privateKey: alicePriv, publicKey: bobPub } of [
privateKey: ec256.privateKey.export({ type: 'pkcs8', format: 'pem' }),
publicKey: x25519.publicKey.export({ type: 'spki', format: 'pem' }),
}, common.mustCall((err) => {
assert.strictEqual(err.code,
hasOpenSSL(3) ? 'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE' :
'ERR_OSSL_EVP_DIFFERENT_KEY_TYPES');
assertErrorCode(err.code, keyTypeMismatchCode);
}));

// Unsupported key type (ed25519)
crypto.diffieHellman({
privateKey: ed25519.privateKey.export({ type: 'pkcs8', format: 'pem' }),
publicKey: ed25519.publicKey.export({ type: 'spki', format: 'pem' }),
}, common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE');
assertErrorCode(err.code, hasOpenSSL(4, 0) ?
/^ERR_OSSL_EVP_(OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE|INTERNAL_ERROR)$/ :
'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE');
}));
}
22 changes: 19 additions & 3 deletions test/parallel/test-crypto-dh-stateless.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,21 @@ const assert = require('assert');
const crypto = require('crypto');
const { hasOpenSSL } = require('../common/crypto');

// Error code for a key-type mismatch during (EC)DH. The underlying OpenSSL
// error code varies by version, and in OpenSSL 4.0 by platform: some builds
// report a generic internal error instead of a typed key-type mismatch.
// https://github.com/openssl/openssl/issues/30895
// TODO(panva): Tighten this check once/if fixed.
let keyTypeMismatchCode;
if (hasOpenSSL(4, 0)) {
keyTypeMismatchCode =
/^ERR_OSSL_EVP_(OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE|INTERNAL_ERROR)$/;
} else if (hasOpenSSL(3)) {
keyTypeMismatchCode = 'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE';
} else {
keyTypeMismatchCode = 'ERR_OSSL_EVP_DIFFERENT_KEY_TYPES';
}

assert.throws(() => crypto.diffieHellman(), {
name: 'TypeError',
code: 'ERR_INVALID_ARG_TYPE',
Expand Down Expand Up @@ -459,12 +474,13 @@ for (const { privateKey: alicePriv, publicKey: bobPub } of [
assert.throws(() => crypto.diffieHellman({
privateKey: ec256.privateKey.export({ type: 'pkcs8', format: 'pem' }),
publicKey: x25519.publicKey.export({ type: 'spki', format: 'pem' }),
}), { code: hasOpenSSL(3) ?
'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE' : 'ERR_OSSL_EVP_DIFFERENT_KEY_TYPES' });
}), { code: keyTypeMismatchCode });

// Unsupported key type (ed25519)
assert.throws(() => crypto.diffieHellman({
privateKey: ed25519.privateKey.export({ type: 'pkcs8', format: 'pem' }),
publicKey: ed25519.publicKey.export({ type: 'spki', format: 'pem' }),
}), { code: 'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE' });
}), { code: hasOpenSSL(4, 0) ?
/^ERR_OSSL_EVP_(OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE|INTERNAL_ERROR)$/ :
'ERR_OSSL_EVP_OPERATION_NOT_SUPPORTED_FOR_THIS_KEYTYPE' });
}
Loading