Use composite keys for package storage to support multiple types#6
Merged
fullstackjam merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
Packages with the same name but different types (e.g. "ghostty" cask vs "ghostty" npm) collided in the selection map, so toggling one would visually toggle both. Switch the map key to "type:name" so each variant is tracked independently.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the package storage mechanism to use composite keys that include both package type and name, enabling proper support for packages that can exist in multiple package managers (e.g., a package available as both a formula and a cask).
Key Changes
pkgKey()helper function in bothConfigEditor.svelteandPackageManager.svelteto generate composite keys in the format{type}:{name}selectedPackagesMap to use composite keys instead of just package names, allowing the same package name to be stored with different typespackageDescsMap to use composite keys for consistency withselectedPackageskey.slice(type.length + 1)Implementation Details
{type}:{name}allows reliable extraction of the package name by removing the type prefix and colonhttps://claude.ai/code/session_01EJFSDndq6gm1SDSjLP1o5x