Skip to content

WIP for test#715

Open
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:test-5.0
Open

WIP for test#715
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:test-5.0

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented May 6, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated catalog image source references from v4.22 to v5.0 for certified-operators, community-operators, and redhat-operators across configuration manifests.

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7fa597af-8524-468a-9a42-3749ad37a6cd

📥 Commits

Reviewing files that changed from the base of the PR and between 5566708 and d6431c1.

📒 Files selected for processing (3)
  • openshift/catalogd/manifests-experimental.yaml
  • openshift/catalogd/manifests.yaml
  • openshift/helm/catalogd.yaml

Walkthrough

Three configuration manifest files update catalog image source references from v4.22 to v5.0 across experimental manifests, standard manifests, and Helm values.

Changes

Catalog Version Upgrade to v5.0

Layer / File(s) Summary
Experimental Manifests
openshift/catalogd/manifests-experimental.yaml
Three ClusterCatalog resources (certified-operators, community-operators, redhat-operators) update image refs from v4.22 to v5.0.
Standard Manifests
openshift/catalogd/manifests.yaml
Three ClusterCatalog resources (openshift-certified-operators, openshift-community-operators, openshift-redhat-operators) update image refs from v4.22 to v5.0.
Helm Configuration
openshift/helm/catalogd.yaml
Helm values under openshift.catalogs version field updated from v4.22 to v5.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Dynamic test names in suite_test.go. Two It() statements use fmt.Sprintf with variable 'name' from image URLs, making test names non-deterministic across test runs. Remove fmt.Sprintf from test names. Use static, fixed strings instead of variables derived from image URLs or other dynamic sources.
Title check ❓ Inconclusive The title 'WIP for test' is vague and generic, using non-descriptive terms that don't convey meaningful information about the actual changeset. Replace the generic title with a specific description of the main change, such as 'Update ClusterCatalog image sources to v5.0' to clearly communicate the purpose of this update.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed Tests demonstrate single responsibility, proper setup/cleanup with DeferCleanup, explicit timeouts (WithTimeout), meaningful error messages, and consistent patterns with helper functions.
Microshift Test Compatibility ✅ Passed PR contains only manifest/config file updates (v4.22 to v5.0 catalog version changes), no new Ginkgo e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It only updates manifest configuration files with version references. The SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only update catalog image version references (v4.22→v5.0), not scheduling logic. No deployment manifests or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR only updates manifest version references. OTE extension main() function properly delegates to cobra/framework without process-level stdout writes. No violations of stdout contract detected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests added in PR. Changes are limited to YAML manifest files (manifests.yaml, manifests-experimental.yaml, catalogd.yaml) updating image references v4.22→v5.0. Check is not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dtfranz and grokspawn May 6, 2026 14:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/default-catalog-consistency d6431c1 link true /test default-catalog-consistency
ci/prow/e2e-aws-olmv1-ext d6431c1 link true /test e2e-aws-olmv1-ext
ci/prow/openshift-e2e-aws d6431c1 link true /test openshift-e2e-aws
ci/prow/e2e-aws-techpreview-olmv1-ext d6431c1 link true /test e2e-aws-techpreview-olmv1-ext
ci/prow/verify-commits d6431c1 link true /test verify-commits
ci/prow/e2e-aws-upgrade-ovn-single-node d6431c1 link false /test e2e-aws-upgrade-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant