sysutils/nextcloud-backup: add option to disable SSL verification#5443
sysutils/nextcloud-backup: add option to disable SSL verification#5443enoch85 wants to merge 1 commit into
Conversation
Adds an optional "Verify SSL certificate" checkbox to the Nextcloud backup settings, defaulting to enabled so existing behavior is preserved. When unchecked, CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST are disabled, allowing the plugin to back up to Nextcloud instances behind self-signed or otherwise untrusted certificates without hand-editing Nextcloud.php after every update. Relates to opnsense#3405 and opnsense#4422.
f803ce1 to
4443de2
Compare
|
We tend to reject these because they degrade security for no reason. It’s easy enough to add the CA or self-signed cert to system: trust: authorities. |
Yeah I get that. It's really just for convenience, and IMHO it's a simple checkbox with a QoL improvement for your users (including me). The default is on, so no real security implications if you don't intentionally tick it. In my case I run let's encrypt and wouldn't that mean adding to authorities every three months? |
|
Let’s encrypt roots should be stable for years. A bit strange they are not in the default store, but they should be readily available for download on their end. |
Ok, thanks! Anyway, please consider it. 🙏🏼 |
|
Please consider using plaintext if you don't want proper trust xD |
Well, I could do it over http since it's on localhost anyway, but... |
Adds an optional "Verify SSL certificate" checkbox to the Nextcloud backup settings.
CURLOPT_SSL_VERIFYPEERandCURLOPT_SSL_VERIFYHOSTare disabled incurl_request_nothrow(), so backups work against Nextcloud instances behind self-signedor otherwise untrusted certificates.
Nextcloud.phpafter every plugin update.Relates to #3405 (accept self-signed certificates) and #4422 (custom CA roots).
Changes:
NextcloudSettings.xml: newverify_sslBooleanField, default 1; model version 1.0.2 -> 1.0.3Nextcloud.php: UI field ingetConfigurationFields(), curl options incurl_request_nothrow()Makefile: plugin version 1.2 -> 1.3pkg-descr: changelog entry