net/wol: make UDP port configurable (default 9)#5448
Open
touzenesmy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
The actual WoL implementation of the plugin doesn't allow for port configuration and default to the 40000 BSOD default value. There is no way to configure the WoL port.
Describe the proposed solution
Add a field port that defaults to 9, users can just use it when they have a specific need as seen previously. I've edited the script to take in that parameter as well.
EDIT: Already modified locally and verified to work on correct ports with packet capture.
Related issue
If this pull request relates to an issue, link it here.
#2967, #4079, #1648