docs: plans for pfv6#3124
Conversation
|
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "docs: plans for pfv6"
} |
|
@adamjohnson please give a careful eye to the /review-a11y skill |
|
@markcaron does the .claude/V6-MIGRATION-PLAN.md say enough about migrating the docs site? |
|
One other note make sure it updates to the latest cem version from the start, otherwise it tries to fumble through a lot of errors. Update: ok a 2nd run i told it to fork from pfv6/plans first and it updated cem, first run went from main and had the older version. |
adamjohnson
left a comment
adamjohnson
left a comment
There was a problem hiding this comment.
Added some comments to the review-a11y skill. We should probably test it on a component or two before letting the harness run wild on the rest of the components.
There was a problem hiding this comment.
Should this file mention the ARIA APG Patterns somewhere? Consider adding a step in Phase 1 to identify the matching APG pattern and use it as the source of truth for expected roles and keyboard behavior.
|
|
||
| For each demo, in each state the element supports: | ||
|
|
||
| #### Chrome |
There was a problem hiding this comment.
Should we instruct the AI to run an axe-core or lighthouse a11y test, then triage the violations before manual inspection?
| declaratively, they must (as of Spring 2026) use ARIA IDL attrs like | ||
| `element.ariaDescribedByElements`. Verify these relationships work via | ||
| ElementInternals ARIA IDL properties or other workarounds. | ||
| Flag any broken cross-root references. |
There was a problem hiding this comment.
Should we also tell the AI to verify a11ySnapshot assertions exist for each state and relationship in tests?
| | Disabled | aria-disabled=true | aria-disabled=true | yes | | ||
|
|
||
| ### Critical Issues | ||
| [Failures that break accessibility] |
There was a problem hiding this comment.
We should probably instruct the AI to classify critical failures with an accompanying WCAG Success Critierion, at least for Critical Issues.
|
|
||
| - All demos demonstrate accessible patterns (no bad advice)? | ||
| - No redundant ARIA roles on elements with implicit roles? | ||
| - Don't treat div as button, etc |
There was a problem hiding this comment.
Consider adding, "Check for WCAG color contrast violations".
3 participants
What I did