feat(Table): add indeterminate checkbox state support for select-all header#12411
Open
rhamilto wants to merge 1 commit intopatternfly:mainfrom
Open
feat(Table): add indeterminate checkbox state support for select-all header#12411rhamilto wants to merge 1 commit intopatternfly:mainfrom
rhamilto wants to merge 1 commit intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughThis PR adds indeterminate checkbox state support to the PatternFly React Table component. A new optional ChangesIndeterminate Checkbox State Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12411.surge.sh A11y report: https://pf-react-pr-12411-a11y.surge.sh |
rhamilto
force-pushed
the
feat/table-indeterminate-checkbox
branch
from
3ab7def to
1b9740e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-table/src/components/Table/SelectColumn.tsx (1)
47-61: 💤 Low value
checkboxPropsduplicates all four fields fromcommonProps— consider eliminating the separate object.PatternFly's
CheckboxsupportsisChecked?: boolean | null, wherenullmeans the checkbox will be indeterminate (partially checked). The override is correct, butcheckboxPropsreplicates all four fields (...props,id,ref,onChange) already present incommonProps. You can eliminate the duplication by building the conditional override directly at the call-site:♻️ Proposed refactor
- // PatternFly Checkbox supports indeterminate via isChecked: null - const checkboxProps = { - ...props, - id, - ref: inputRef, - onChange: handleChange, - ...(isIndeterminate && { isChecked: null }) - }; - const commonProps = { ...props, id, ref: inputRef, onChange: handleChange };- <Checkbox {...checkboxProps} /> + <Checkbox {...commonProps} {...(isIndeterminate && { isChecked: null })} />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/react-table/src/components/Table/SelectColumn.tsx` around lines 47 - 61, Remove the duplicated object by using commonProps as the base and applying the indeterminate override only where Checkbox is rendered: delete the separate checkboxProps declaration and, at the Checkbox render site, spread commonProps and conditionally include isChecked: null when isIndeterminate is true (preserving ...props, id, ref: inputRef, onChange: handleChange from commonProps). Keep the identifier names isIndeterminate, commonProps and checkbox behavior consistent with PatternFly's Checkbox which accepts isChecked?: boolean | null.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/react-table/src/components/Table/SelectColumn.tsx`:
- Around line 47-61: Remove the duplicated object by using commonProps as the
base and applying the indeterminate override only where Checkbox is rendered:
delete the separate checkboxProps declaration and, at the Checkbox render site,
spread commonProps and conditionally include isChecked: null when
isIndeterminate is true (preserving ...props, id, ref: inputRef, onChange:
handleChange from commonProps). Keep the identifier names isIndeterminate,
commonProps and checkbox behavior consistent with PatternFly's Checkbox which
accepts isChecked?: boolean | null.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 407847d8-4ecd-4bbc-80dc-1d367e75dd63
📒 Files selected for processing (8)
packages/react-table/src/components/Table/SelectColumn.tsxpackages/react-table/src/components/Table/TableTypes.tsxpackages/react-table/src/components/Table/Th.tsxpackages/react-table/src/components/Table/base/types.tsxpackages/react-table/src/components/Table/examples/Table.mdpackages/react-table/src/components/Table/examples/TableSelectable.tsxpackages/react-table/src/components/Table/examples/TableSelectableIndeterminate.tsxpackages/react-table/src/components/Table/utils/decorators/selectable.tsx
✅ Files skipped from review due to trivial changes (2)
- packages/react-table/src/components/Table/examples/TableSelectable.tsx
- packages/react-table/src/components/Table/examples/Table.md
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/react-table/src/components/Table/utils/decorators/selectable.tsx
- packages/react-table/src/components/Table/Th.tsx
Member
Author
|
cc: @nicolethoen, this is needed to complete openshift/console#16203 |
rhamilto
force-pushed
the
feat/table-indeterminate-checkbox
branch
from
1b9740e to
a99a368
Compare
…header
Add support for indeterminate state to the Table component's select-all
checkbox, following PatternFly's bulk selection design guidelines.
The select-all checkbox now supports three states:
- Unchecked: no items selected
- Indeterminate: some items selected (shows dash/minus icon)
- Checked: all items selected
## Changes
- Add `isIndeterminate?: boolean` property to `ThSelectType` interface
- Add `isIndeterminate?: boolean` to `IColumn` extraParams type
- Update `Th` component to pass `isIndeterminate` to the selectable decorator
- Update `selectable` decorator to pass indeterminate state to `SelectColumn`
- Update `SelectColumn` to use PatternFly Checkbox's native indeterminate support (isChecked: null)
- Add new `TableSelectableIndeterminate` example showcasing the feature
## Implementation
The indeterminate state is implemented using the PatternFly Checkbox component's
native support by setting `isChecked: null` when `isIndeterminate` is true.
## Usage
```typescript
const areSomeReposSelected = selectedRepoNames.length > 0 && selectedRepoNames.length < selectableRepos.length;
<Th
select={{
onSelect: (_event, isSelecting) => selectAllRepos(isSelecting),
isSelected: areAllReposSelected,
isIndeterminate: areSomeReposSelected
}}
aria-label="Row select"
/>
```
Fixes patternfly#12404
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rhamilto
force-pushed
the
feat/table-indeterminate-checkbox
branch
from
a99a368 to
6308f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for indeterminate state to the Table component's select-all checkbox in the header, following PatternFly's bulk selection design guidelines.
The select-all checkbox now properly supports three states:
Changes
isIndeterminate?: booleanproperty toThSelectTypeinterfaceisIndeterminate?: booleantoIColumnextraParams typeThcomponent to passisIndeterminateto the selectable decoratorselectabledecorator to pass indeterminate state toSelectColumnSelectColumnto use PatternFly Checkbox's native indeterminate support (isChecked: null)TableSelectableIndeterminateexample showcasing the featureTechnical implementation
The indeterminate state is implemented using the PatternFly Checkbox component's native support by setting
isChecked: nullwhenisIndeterminateis true. This leverages PatternFly's built-in indeterminate checkbox handling.Usage example
Related issues
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes