Fix apps update failing on empty group inputs with de-client>=1.10.0#40
Open
Fix apps update failing on empty group inputs with de-client>=1.10.0#40
Conversation
Skip --add-group-co-owner / --add-group-viewer when their inputs are empty, and fix typos in input types (strong -> string, boolean -> string for group_viewers / group_co_owners). de-client 1.10.0 strictly validates group names and rejects empty strings, breaking workflows that don't set these inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workflows using
plotly/de-deploy@mainwithde_client_version: '1.10.0'(or any 1.10.x release) and nogroup_co_owners/group_viewersinputs fail at the post-deploy step with:The failing call is from the existing
Inject code and deploystep, which always invoked:When neither input is provided, this expands to literal empty strings:
In
de-client1.9.5 the empty lookup was a silent no-op. In 1.10.0 a new strict-validation block incli/apps.pydiffs requested names against found names and exits 1 when any are missing — empty strings are reported as missing.Fix
Build the args array conditionally and only invoke
apps updatewhen at least one group input is non-empty. Each flag is added independently so workflows that set only one of the two also work.Also fixes two unrelated input-type typos:
group_viewers.type: strong->stringgroup_co_owners.type: boolean->stringVerification
After this change, with
de_client_version: '1.10.0':apps updatecall is skipped entirely (no moreGroup '' could not be founderror).group_co_ownersset -> runsapps update --add-group-co-owner <value>.group_viewersset -> runsapps update --add-group-viewer <value>.apps update --add-group-co-owner <a> --add-group-viewer <b>.A separate report should also be filed against
plotly/de-clientso the strict validation in 1.10.x ignores empty-string entries — that would prevent the same failure in any other tooling that templates these flags from possibly-empty values.