Skip to content

Fix apps update failing on empty group inputs with de-client>=1.10.0#40

Open
RunQi-Han wants to merge 1 commit intomainfrom
fix/empty-group-flags-de-client-1.10
Open

Fix apps update failing on empty group inputs with de-client>=1.10.0#40
RunQi-Han wants to merge 1 commit intomainfrom
fix/empty-group-flags-de-client-1.10

Conversation

@RunQi-Han
Copy link
Copy Markdown

Problem

Workflows using plotly/de-deploy@main with de_client_version: '1.10.0' (or any 1.10.x release) and no group_co_owners / group_viewers inputs fail at the post-deploy step with:

Error updating app [<app-name>]: Group '' could not be found on <host>.
Error: Process completed with exit code 1.

The failing call is from the existing Inject code and deploy step, which always invoked:

de --no-keyfile apps update --name $APP_NAME \
   --add-group-co-owner "${{ inputs.group_co_owners }}" \
   --add-group-viewer "${{ inputs.group_viewers }}"

When neither input is provided, this expands to literal empty strings:

de --no-keyfile apps update --name de5-de-deploy --add-group-co-owner "" --add-group-viewer ""

In de-client 1.9.5 the empty lookup was a silent no-op. In 1.10.0 a new strict-validation block in cli/apps.py diffs requested names against found names and exits 1 when any are missing — empty strings are reported as missing.

Fix

Build the args array conditionally and only invoke apps update when at least one group input is non-empty. Each flag is added independently so workflows that set only one of the two also work.

Also fixes two unrelated input-type typos:

  • group_viewers.type: strong -> string
  • group_co_owners.type: boolean -> string

Verification

After this change, with de_client_version: '1.10.0':

  • Neither group input set -> the apps update call is skipped entirely (no more Group '' could not be found error).
  • Only group_co_owners set -> runs apps update --add-group-co-owner <value>.
  • Only group_viewers set -> runs apps update --add-group-viewer <value>.
  • Both set -> runs apps update --add-group-co-owner <a> --add-group-viewer <b>.

A separate report should also be filed against plotly/de-client so the strict validation in 1.10.x ignores empty-string entries — that would prevent the same failure in any other tooling that templates these flags from possibly-empty values.

Skip --add-group-co-owner / --add-group-viewer when their inputs are empty, and fix typos in input types (strong -> string, boolean -> string for group_viewers / group_co_owners). de-client 1.10.0 strictly validates group names and rejects empty strings, breaking workflows that don't set these inputs.
@RunQi-Han RunQi-Han requested a review from michaelbabyn May 5, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant