Skip to content

feat(cli): implement config payments list#260

Open
BogdanMaryniuk wants to merge 2 commits into
profullstack:masterfrom
BogdanMaryniuk:feat/config-list-command-fork
Open

feat(cli): implement config payments list#260
BogdanMaryniuk wants to merge 2 commits into
profullstack:masterfrom
BogdanMaryniuk:feat/config-list-command-fork

Conversation

@BogdanMaryniuk
Copy link
Copy Markdown

Closes #259\n\n## Summary\n- replaces the sh1pt config payments list stub with a read-only manifest reader for sh1pt.config.ts\n- shows provider key, adapter id, enabled/disabled state, default provider, and platform fee when configured\n- adds --json and --config <path> for scripts/smoke tests\n- covers the parser with focused Vitest tests\n\n## Verification\n- pnpm exec vitest run packages/cli/src/commands/config.test.ts\n- pnpm --filter @profullstack/sh1pt typecheck\n- git diff --check\n- pnpm exec tsx packages/cli/src/index.ts config payments list --config boilerplates/axum-supabase/sh1pt.config.ts\n- pnpm exec tsx packages/cli/src/index.ts config payments list --json --config boilerplates/axum-supabase/sh1pt.config.ts

@BogdanMaryniuk
Copy link
Copy Markdown
Author

Security scan note: the vu1nz review itself completed with 0 findings, but the workflow failed in the final Comment on PR step because GitHub Actions returned Resource not accessible by integration for a forked PR comment.\n\nRelevant local/CI verification remains green:\n- pnpm exec vitest run packages/cli/src/commands/config.test.ts\n- pnpm --filter @profullstack/sh1pt typecheck\n- git diff --check\n- GitHub test check passed\n- Socket checks passed\n\nSo this looks like a workflow permissions issue, not a code/security failure.

@ralyodio
Copy link
Copy Markdown
Contributor

Hey @BogdanMaryniuk — the failing vu1nz security scan check is a CI issue on our side (fork PRs get a read-only token and can't post the review comment). I just pushed a fix to master in b3290b8.

Could you rebase this branch on master so the workflow picks up the fix? Something like:

git fetch upstream
git rebase upstream/master
git push --force-with-lease

Thanks!

@ralyodio
Copy link
Copy Markdown
Contributor

Update: I went ahead and triggered "Update branch" on this PR, so the rebase isn't needed anymore — CI should re-run with the fixed workflow shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement config payments list from sh1pt.config.ts

2 participants