Skip to content

Fix sleeping before taking a screenshot in Map._to_png #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansthen merged 2 commits into from
May 1, 2026
Merged

Fix sleeping before taking a screenshot in Map._to_png #2220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf5fbe
fix falsely named function parameter in docstring of Map._to_png
neezr Apr 28, 2026
8fee45d
replace time.sleep() with smarter WebDriverWait() in Map._to_png
neezr Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions folium/folium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def _to_png(
Examples
--------
>>> m._to_png()
>>> m._to_png(time=10) # Wait 10 seconds between render and snapshot.
>>> m._to_png(delay=10) # Wait 10 seconds between render and snapshot.

"""

Expand All @@ -392,11 +392,16 @@ def _to_png(
*size,
)
driver.set_window_size(*window_size)
from selenium.webdriver.support.ui import WebDriverWait

html = self.get_root().render()
with temp_html_filepath(html) as fname:
# We need the tempfile to avoid JS security issues.
driver.get(f"file:///{fname}")
time.sleep(delay)
WebDriverWait(driver, delay).until(
lambda _driver: _driver.execute_script("return document.readyState")
== "complete"
)
div = driver.find_element("class name", "folium-map")
png = div.screenshot_as_png
driver.quit()
Expand Down
Loading