gh-149425: Increase test_write_without_source_date_epoch assertion delta#149426
gh-149425: Increase test_write_without_source_date_epoch assertion delta#149426brettcannon merged 3 commits intopython:mainfrom
test_write_without_source_date_epoch assertion delta#149426Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <brett@python.org>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
|
Thanks @edvilme for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @edvilme and @brettcannon, I could not cleanly backport this to |
|
GH-149433 is a backport of this pull request to the 3.14 branch. |
…ertion delta (GH-149426) (#149433) gh-149425: Increase `test_write_without_source_date_epoch` assertion delta (GH-149426) (cherry picked from commit 17975f9) Co-authored-by: Eduardo Villalpando Mello <eduardo.villalpando.mello@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Brett Cannon <brett@python.org>
This pull request makes a minor adjustment to a test in
test_core.pyto allow for a slightly larger difference in timestamp values when comparing ZIP file metadata to the current time.assertAlmostEqualcheck from 1 to 2 in thetest_write_without_source_date_epochtest, to reduce test flakiness due to timing differences. (Lib/test/test_zipfile/test_core.py)Fixes #149425