Skip to content

gh-149425: Increase test_write_without_source_date_epoch assertion delta#149426

Merged
brettcannon merged 3 commits intopython:mainfrom
edvilme:edvilme-fix-test
May 5, 2026
Merged

gh-149425: Increase test_write_without_source_date_epoch assertion delta#149426
brettcannon merged 3 commits intopython:mainfrom
edvilme:edvilme-fix-test

Conversation

@edvilme
Copy link
Copy Markdown
Contributor

@edvilme edvilme commented May 5, 2026

This pull request makes a minor adjustment to a test in test_core.py to allow for a slightly larger difference in timestamp values when comparing ZIP file metadata to the current time.

  • Increased the allowable delta in the assertAlmostEqual check from 1 to 2 in the test_write_without_source_date_epoch test, to reduce test flakiness due to timing differences. (Lib/test/test_zipfile/test_core.py)

Fixes #149425

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 5, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 5, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented May 5, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

Comment thread Misc/NEWS.d/next/Tests/2026-05-05-18-49-44.gh-issue-149425.QnQL8j.rst Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 5, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Brett Cannon <brett@python.org>
@edvilme
Copy link
Copy Markdown
Contributor Author

edvilme commented May 5, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 5, 2026

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from brettcannon May 5, 2026 21:18
@brettcannon brettcannon merged commit 17975f9 into python:main May 5, 2026
57 of 60 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @edvilme for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

Sorry, @edvilme and @brettcannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 17975f92edd2a6a84549e19f683f78a96992ec80 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 5, 2026

GH-149433 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 5, 2026
brettcannon added a commit that referenced this pull request May 5, 2026
…ertion delta (GH-149426) (#149433)

gh-149425: Increase `test_write_without_source_date_epoch` assertion delta (GH-149426)
(cherry picked from commit 17975f9)

Co-authored-by: Eduardo Villalpando Mello <eduardo.villalpando.mello@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.13 bugs and security fixes tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Up the tolerance for test.test_zipfile.test_core.OtherTests.test_write_without_source_date_epoch

3 participants