Rewrite RTD configuration to use build.jobs rather than build.commands#149429
Rewrite RTD configuration to use build.jobs rather than build.commands#149429zware wants to merge 4 commits intopython:mainfrom
Conversation
zware
force-pushed
the
rewrite_rtd_config
branch
2 times, most recently
from
dfcae69 to
7438633
Compare
| then | ||
| base_branch=main; | ||
| git fetch --depth=50 origin $base_branch; | ||
| for attempt in $(seq 10); |
There was a problem hiding this comment.
I think @StanFromIreland added a bash script for progressive unshallowing some time ago based on my experiments elsewhere. We could probably reuse that.
There was a problem hiding this comment.
Oh, he embedded bash in YAML: #147975 (comment). But perhaps, if it's extracted into Tools/, we could deduplicate the logic.
There was a problem hiding this comment.
Deduplicating sounds good, but I think I'll leave that for a later cleanup.
…commands --no-stat on merge
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
GH-149432 is a backport of this pull request to the 3.14 branch. |
|
Opened the backport ahead of time because it needs to be manually adjusted anyway, and I want to make sure it doesn't do anything too weird on the 3.14 branch. |
… build.commands (pythonGH-149429) --set-upstream on initial fetch
… build.commands (pythonGH-149429) no --set-upstream, add explicit origin/?
| set -eEux; | ||
| if [ "$READTHEDOCS_VERSION_TYPE" = "external" ]; | ||
| then | ||
| base_branch=main; |
There was a problem hiding this comment.
Is there an env var that could be used instead of main? I imagine this isn't going to work well in backport PRs unless we check against stable branches.
There was a problem hiding this comment.
My plan is to manually set base_branch to the right branch in each backport; I'm afraid RTD doesn't provide the base branch anywhere (that's documented, anyway).
2 participants
No description provided.