Fix negative narrowing for containers#21411
Merged
hauntsaninja merged 2 commits intopython:masterfrom May 5, 2026
Merged
Conversation
Fixes python#21409 Relevant tests for the special case are in testNarrowingOptionalEqualsNone Co-authored-by Codex
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
added a commit
that referenced
this pull request
May 5, 2026
Fixes #21409 While we may be able to conclude `if color != Color.RED` is unreachable, we cannot do so for containment Relevant tests for the special case are in testNarrowingOptionalEqualsNone Co-authored-by Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21409
While we may be able to conclude
if color != Color.REDis unreachable, we cannot do so for containmentRelevant tests for the special case are in testNarrowingOptionalEqualsNone
Co-authored-by Codex