fix(latex): treat fmtutil-sys failure as non-fatal during package install#14490
Merged
Conversation
Returns a warning message when `fmtutil-sys --all` exits non-zero, or undefined on success. Lets callers log a warning and continue rather than aborting. Matches the upstream tinytex R package pattern, which ignores the `fmtutil` exit code. Refs: #14461
Both recovery branches in `installPackage` previously aborted the render with `Problem running fmtutil-sys --all to rebuild format tree.` whenever fmtutil exited non-zero. Format-tree rebuild is best-effort housekeeping after `tlmgr update`; the package install itself has already succeeded by that point. Log a warning and continue, mirroring upstream tinytex R behavior. Fixes #14461
Mirrors the `tlmgrCommand` pattern: invoke through a temp .bat with `cmd /c`. Defends against 8.3 short-path resolution failures inside TeX Live's `runscript.tlu` (rstudio/tinytex#427) when Deno spawns the process directly. Refs: #14461
`safeWindowsExec` joins program + args into a `.bat` command line with literal spaces, so paths containing spaces would be tokenized incorrectly (e.g. `C:\Users\Jane Doe\...`). Mirrors the documented pattern from the `safeWindowsExec - handles program path with spaces` unit test (#13997). Refs: #14461
Captures the pattern hit while wiring fmtutil-sys: `safeWindowsExec` needs `requireQuoting` on both program path and args, otherwise the generated .bat tokenizes incorrectly when paths contain spaces. Points to the #13997 test and existing call sites as authoritative refs.
Earlier wording implied tlmgr/fmtutil/reg.exe were the full set; `zip.ts` and `shell.ts` are also callers. Reframe as examples + tell readers to grep when they need the current list.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
quarto render --to pdftriggered automatic LaTeX package installation and the post-updatefmtutil-sys --allstep exited non-zero, the entire render aborted withERROR: Problem running 'fmtutil-sys --all' to rebuild format tree.even though the package install itself had already succeeded (or was about to be retried).Root Cause
Both recovery branches in
installPackage(src/command/render/latexmk/texlive.ts) reject whenfmtutil-sysexits non-zero. Thefmtutil-sys --allcall was added in #7252 to mitigate l3kernel version mismatches aftertlmgr update --all, mirroring upstreamtinytexR behavior — but the upstreamtinytexdiscards thesystem2('fmtutil', ...)exit code (R/tlmgr.R,R/latex.R). Quarto's port treats it as fatal instead.fmtutil-sysfailures are environment-specific (locale, antivirus, transient locks, format-tree state) and unrelated to whether the package install succeeded. Format-tree rebuild is best-effort housekeeping.Fix
installPackagenow logs a warning via a smallfmtutilFailureMessage(result)helper and continues, matching upstream behavior. Unit tests cover the helper (tests/unit/latexmk/fmtutil-handler.test.ts).fmtutilCommandis also routed throughsafeWindowsExecon Windows (mirrorstlmgrCommand) as defense againstrunscript.tlushort-path resolution failures (rstudio/tinytex#427). The program path + args are pre-quoted viarequireQuotingper the documentedsafeWindowsExec - handles program path with spacestest (#13997). A new rule doc (.claude/rules/typescript/windows-safe-exec.md) captures therequireQuoting-before-safeWindowsExecconvention so future call sites pick it up by default.Out of scope:
pdf.tscallspkgMgr.updatePackages(true, false)outsideinstallPackagewithout ever runningfmtutil— pre-existing gap unrelated to the abort behavior fixed here.Fixes #14461