services/polkit: refactor authentication request queueing#800
Open
MrAdityaAlok wants to merge 1 commit into
Open
services/polkit: refactor authentication request queueing#800MrAdityaAlok wants to merge 1 commit into
MrAdityaAlok wants to merge 1 commit into
Conversation
- Relying on `queuedRequests.size() == 1` is buggy as it allows newer requests to takeover the currently active one. - Now we rely on `bActiveFlow.value()` being `nullptr`. - Process requests linearly until we find a valid request to prevent deadlock. Signed-off-by: Aditya Alok <dev.aditya.alok@gmail.com>
MrAdityaAlok
force-pushed
the
fix-polkitagent
branch
from
148c6c6 to
c2ac98d
Compare
MrAdityaAlok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queuedRequests.size() == 1is buggy as it allows newerrequests to takeover the currently active one.
bActiveFlow.value()beingnullptr.deadlock.