Skip to content

Avoid spamming too many deprecations while parsing #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
May 1, 2026
+86 −76
Merged

Avoid spamming too many deprecations while parsing #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ typedef struct JSON_ParserStateStruct {
rvalue_cache name_cache;
int in_array;
int current_nesting;
unsigned int emitted_deprecations;
} JSON_ParserState;

static inline size_t rest(JSON_ParserState *state) {
Expand Down Expand Up @@ -945,7 +946,12 @@ static inline VALUE json_decode_object(JSON_ParserState *state, JSON_ParserConfi
case JSON_IGNORE:
break;
case JSON_DEPRECATED:
emit_duplicate_key_warning(state, json_find_duplicated_key(count, pairs));
// Only emit the first few deprecations to avoid spamming.
if (state->emitted_deprecations < 5) {
emit_duplicate_key_warning(state, json_find_duplicated_key(count, pairs));
state->emitted_deprecations++;
}

break;
case JSON_RAISE:
raise_duplicate_key_error(state, json_find_duplicated_key(count, pairs));
Expand Down
Loading