Open
Conversation
ledsun
force-pushed
the
codex/update-ruby-wasm-wasi-dev-deps
branch
from
9dca031 to
daea25e
Compare
ledsun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
@ruby/wasm-wasidevelopment dependency set and refresh the lockfile.This includes:
@bytecodealliance/jco,@rollup/plugin-typescript,@types/node,prettier,typescript, andvitestjcooutput formatNotes
I have kept TypeScript at the latest 5.9.x release. TypeScript 6 generates numerous type errors for existing code.
About Failed Jobs
The failing jobs appear unrelated to this dependency update.
The observed failures happen while building Docker builder images, before the package build/test steps for this PR run. One failure downloads
wasi-preset-argsfrom a GitHub Release asset and then fails to unzip it because the downloaded file is not a valid zip. Another failure is in the NodeSource apt setup path.This PR only changes the
@ruby/wasm-wasinpm dev dependencies, generated WIT typings, and the Rollup/Vitest config needed for those updates. Local validation passed:node packages/npm-packages/ruby-wasm-wasi/tools/component-ts-bindgen.mjsnpm -C packages/npm-packages/ruby-wasm-wasi run buildRUBY_NPM_PACKAGE_ROOT=../ruby-head-wasm-wasi npm -C packages/npm-packages/ruby-wasm-wasi run test:vitest -- --runRUBY_NPM_PACKAGE_ROOT=../ruby-head-wasm-wasi npm -C packages/npm-packages/ruby-wasm-wasi run test:unitA rerun of the failed jobs is likely the next step, but I do not have permission to trigger it.