fix: expect oclif parse exit code 2 for invalid-input NUTs @W-22403352#414
Merged
EstebanRomero84 merged 2 commits intomainfrom May 7, 2026
Merged
fix: expect oclif parse exit code 2 for invalid-input NUTs @W-22403352#414EstebanRomero84 merged 2 commits intomainfrom
EstebanRomero84 merged 2 commits intomainfrom
Conversation
Six NUT cases asserted ensureExitCode: 1 but the commands fail at
oclif flag-parse time (Flags.file({ exists: true }), parse callbacks
that throw, validate callbacks, and missing required flags), which
exits with code 2. Update the assertions to match.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The exit code for these oclif parse failures differs by sf-plugins-core version: 12.2.6 (bundled in CLI 2.135.0) emits 2, while 12.2.13 (used in plugin-agent's own CI) catches the parse error and re-emits exit 1. Use 'nonZero' so the assertion is correct in both environments. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
EstebanRomero84
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six NUT cases asserted ensureExitCode: 1 but the commands fail at oclif flag-parse time (Flags.file({ exists: true }), parse callbacks that throw, validate callbacks, and missing required flags), which exits with code 2. Update the assertions to match.
@W-22403352@