Skip to content

improvement(logs): increase log details panel max width from 40vw to 60vw#4449

Merged
waleedlatif1 merged 2 commits intostagingfrom
fix/log
May 5, 2026
Merged

improvement(logs): increase log details panel max width from 40vw to 60vw#4449
waleedlatif1 merged 2 commits intostagingfrom
fix/log

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Increased the max draggable width of the log details side panel from 40vw to 60vw

Type of Change

  • Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 5, 2026 6:12pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk UI-only change that adjusts log details panel sizing constraints; main risk is unintended layout/overflow on smaller viewports.

Overview
Allows the log details side panel to be resized wider by increasing MAX_LOG_DETAILS_WIDTH_RATIO from 0.4 to 0.6, which updates both the runtime clamp (getMaxLogDetailsWidth/clampPanelWidth) and the CSS vw cap used by log-details.tsx.

Documentation comments are updated to reflect the new 60% viewport-width limit.

Reviewed by Cursor Bugbot for commit 79facfc. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 5, 2026

Greptile Summary

This PR increases the maximum draggable width of the log details side panel from 40vw to 60vw by changing MAX_LOG_DETAILS_WIDTH_RATIO from 0.4 to 0.6 in apps/sim/stores/logs/utils.ts.

  • The constant, JSDoc on getMaxLogDetailsWidth, and the inline comment in clampPanelWidth are all updated and now consistent with the new 60vw cap.
  • No logic changes — clampPanelWidth and getMaxLogDetailsWidth consume the constant unchanged, so the wider limit flows through automatically.

Confidence Score: 5/5

Single-constant change with no logic modifications — safe to merge.

The change touches only one constant and its accompanying documentation. All three JSDoc references are now consistent with the new 60vw cap, and the clamping logic that consumes the constant is unchanged. There are no new code paths, no state mutations, and no risk of regressions.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/stores/logs/utils.ts Increases MAX_LOG_DETAILS_WIDTH_RATIO from 0.4 to 0.6 and updates all JSDoc references from 65vw to 60vw — change is internally consistent and well-documented

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User drags panel] --> B[clampPanelWidth called]
    B --> C[getMaxLogDetailsWidth]
    C --> D{window defined?}
    D -- Yes --> E[window.innerWidth × 0.6]
    D -- No / SSR --> F[fallback: 1040px]
    E --> G[max]
    F --> G
    G --> H[min = Math.min 320px, max]
    H --> I[Math.max min, Math.min width, max]
    I --> J[Clamped panel width ≤ 60vw]
Loading

Reviews (2): Last reviewed commit: "chore(logs): fix stale 65vw references i..." | Re-trigger Greptile

Comment thread apps/sim/stores/logs/utils.ts Outdated
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

Fixed in 79facfc — both stale JSDoc references updated from 65vw/65% to 60vw/60%.

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 79facfc. Configure here.

@waleedlatif1 waleedlatif1 merged commit af84019 into staging May 5, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/log branch May 5, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant