fix(session): use @solidjs/start/http instead of vinxi/http#1470
Open
tknkaa wants to merge 2 commits intosolidjs:mainfrom
Open
fix(session): use @solidjs/start/http instead of vinxi/http#1470tknkaa wants to merge 2 commits intosolidjs:mainfrom
tknkaa wants to merge 2 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brenelz
reviewed
May 6, 2026
|
|
||
| ```ts title="src/lib/session.ts" | ||
| import { useSession } from "vinxi/http"; | ||
| import { useSession } from "@solidjs/start/http"; |
Collaborator
There was a problem hiding this comment.
this is a SolidStart v2 change correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The session.mdx example imports
useSessionfromvinxi/http, but this causes a runtime error in SolidStart v2 default setup (created via CLI).Changing the import to
@solidjs/start/httpresolves the error.Related issues & labels