fix(jwt): reject empty JWT-SVID audiences#431
Open
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Open
fix(jwt): reject empty JWT-SVID audiences#431maxlambrecht wants to merge 1 commit intospiffe:mainfrom
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
fix/jwt-svid-empty-audience
branch
from
b6d2e49 to
4bc8a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject empty expected audience sets in JWT-SVID validation for both
JwtSvid.parseAndValidate(...)andJwtSvid.parseInsecure(...).Why
Passing an empty expected audience set previously caused audience validation to succeed because
containsAll(emptySet())is always true. This was a failure-open behavior in a security-sensitive validator.This is an observable behavior change: empty expected audiences now throw
IllegalArgumentException("audience cannot be empty").How tested
Ran the focused JWT-SVID validation tests:
./gradlew :java-spiffe-core:test --tests 'io.spiffe.svid.jwtsvid.JwtSvidParseAndValidateTest' --tests 'io.spiffe.svid.jwtsvid.JwtSvidParseInsecureTest'