fix(golang): cast string-enum fields in MySQL copyfrom encoder#4428
Open
SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
Open
fix(golang): cast string-enum fields in MySQL copyfrom encoder#4428SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
mysqltsv.AppendValue uses a strict type-switch and rejects string-derived enum types (e.g. ExperienceLocationsType) with "can't encode type X to TSV". Detect string enums in the go-sql-driver-mysql copyfrom template and emit AppendString(string(field)) instead. Fixes sqlc-dev#4324 Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4324.
mysqltsv.AppendValueuses a strict type-switch and rejects string-derived enum types (e.g.type ExperienceLocationsType string) withcan't encode type X to TSV. The MySQL copyfrom template now detects fields whoseTypematches a generated enum (bare ormodels.-qualified) and emitse.AppendString(string(row.Field))instead ofe.AppendValue(row.Field).A regression test under
internal/endtoend/testdata/copyfrom_mysql_enum/mysql/mirrors the reporter's schema and query; it fails onmainand passes with this change. All other replay tests still pass.