feat: add blas/ext/base/glast-index-of-row#11929
Open
headlessNode wants to merge 4 commits intostdlib-js:developfrom
Open
feat: add blas/ext/base/glast-index-of-row#11929headlessNode wants to merge 4 commits intostdlib-js:developfrom
blas/ext/base/glast-index-of-row#11929headlessNode wants to merge 4 commits intostdlib-js:developfrom
Conversation
stdlib-bot
added
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
headlessNode
added
Feature
Member
Author
|
No need for 'base.js` |
kgryte
reviewed
May 5, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
May 5, 2026
| } | ||
| }); | ||
|
|
||
| tape( 'the function returns an invalid index when M is less than or equal to zero', function test( t ) { |
Member
There was a problem hiding this comment.
You need to include tests for accessor arrays.
kgryte
reviewed
May 5, 2026
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns an invalid index when M is less than or equal to zero (row-major)', function test( t ) { |
Member
There was a problem hiding this comment.
You need to include tests for accessor arrays.
kgryte
requested changes
May 5, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Other than missing tests, this is looking good.
Given that changes already need to be made, it would be good to go ahead and update the description of LDA throughout this PR.
kgryte
added
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#221.
Description
This pull request:
blas/ext/base/glast-index-of-rowRelated Issues
This pull request has the following related issues:
blas/ext/base/glast-index-of-rowmetr-issue-tracker#221Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Primarily written by Claude Code.
@stdlib-js/reviewers