fix(useLocalStorage): replace useLayoutEffect with useIsomorphicLayoutEffect#2702
Open
DISCONECTED-png wants to merge 1 commit intostreamich:masterfrom
Open
Conversation
…tEffect useLayoutEffect causes a React warning when rendered server-side because it does not exist in SSR environments. The library already exports useIsomorphicLayoutEffect which automatically falls back to useEffect on the server — the same pattern used in createGlobalState. Relates to: streamich#956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
useLocalStorageimports and usesuseLayoutEffectdirectly from React (line 1 & 56),which causes this warning in SSR environments:
Fix
Replaced
useLayoutEffectwithuseIsomorphicLayoutEffect— the utility alreadyexported by this library — which automatically falls back to
useEffecton theserver and uses
useLayoutEffectin the browser.This is the same pattern already used in
createGlobalState.ts(fixed in #956).Relates to: #956