Build and path handling adjustments to handle both old build system and swift-build#740
Merged
Merged
Conversation
The way we're looking up the swift-java "tool" in plugins uses the target name "SwiftJavaTool" and that is correct in the natrive build system. In swift 6.4, and in Xcode, the swift-build build system is actually naming them using product names: so swift-java. In order to have the build work in BOTH build systems, we have to make the name be the same... It's a workaround, but it seems to work. This should resolve the failure ``` error: Build input file cannot be found: '/Users/ktoso/code/swift-java/Samples/JavaKitSampleApp/.build/out/Products/Debug/SwiftJavaTool'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? ``` that folks were reporting in swiftlang#733 and in swiftlang#281
ktoso
changed the title
Collaborator
Author
|
I'll put up PRs to revert workarounds as the root causes get fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we're looking up the swift-java "tool" in plugins uses the target name "SwiftJavaTool" and that is correct in the natrive build system.
In swift 6.4, and in Xcode, the swift-build build system is actually naming them using product names: so swift-java. In order to have the build work in BOTH build systems, we have to make the name be the same... It's a workaround, but it seems to work.
This should resolve the failure
error: Build input file cannot be found: '/Users/ktoso/code/swift-java/Samples/JavaKitSampleApp/.build/out/Products/Debug/SwiftJavaTool'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it?that folks were reporting in #733 and in #281
resolves #281
resolves #733