Conversation
- onMemery -> onMemory in Cache.swift - peformChange -> performChange in DiskCache.swift - Entiries -> Entries in LRUCache.swift --- Generated-by: google/gemma-4-26b-a4b Co-authored-by: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects several typos in variable and method names across the codebase, including renaming 'onMemery' to 'onMemory' and 'peformChange' to 'performChange'. Feedback from the reviewer highlights a critical issue where the 'await' keyword is incorrectly used alongside 'async let' declarations in 'Cache.swift', which will cause compiler errors. Code suggestions were provided to resolve these syntax issues.
| queueingTask.enqueueAndReplacing { [weak self] in | ||
| guard let self else { return } | ||
| async let memory: Void = await onMemery.store(value, for: key).value | ||
| async let memory: Void = await onMemory.store(value, for: key).value |
There was a problem hiding this comment.
The await keyword should not be used on the right-hand side of an async let declaration. The asynchronous nature of the expression is already implied by async let. Using await here will result in a compiler error.
Note: This issue also exists on line 72, which is not part of the current changes.
| async let memory: Void = await onMemory.store(value, for: key).value | |
| async let memory: Void = onMemory.store(value, for: key).value |
| queueingTask.enqueueAndReplacing { [weak self] in | ||
| guard let self else { return } | ||
| async let memory: Void = await onMemery.remove(for: key).value | ||
| async let memory: Void = await onMemory.remove(for: key).value |
There was a problem hiding this comment.
The await keyword should not be used on the right-hand side of an async let declaration. The asynchronous nature of the expression is already implied by async let. Using await here will result in a compiler error.
Note: This issue also exists on line 91, which is not part of the current changes.
| async let memory: Void = await onMemory.remove(for: key).value | |
| async let memory: Void = onMemory.remove(for: key).value |
| queueingTask.enqueueAndReplacing { [weak self] in | ||
| guard let self else { return } | ||
| async let memory: Void = await onMemery.removeAll().value | ||
| async let memory: Void = await onMemory.removeAll().value |
There was a problem hiding this comment.
The await keyword should not be used on the right-hand side of an async let declaration. The asynchronous nature of the expression is already implied by async let. Using await here will result in a compiler error.
Note: This issue also exists on line 110, which is not part of the current changes.
| async let memory: Void = await onMemory.removeAll().value | |
| async let memory: Void = onMemory.removeAll().value |
- sweeped -> swept in DiskCache.swift --- Generated-by: google/gemma-4-26b-a4b Co-authored-by: Claude <noreply@anthropic.com>
1 participant
Summary
onMemerytoonMemoryinCache.swiftpeformChangetoperformChangeinDiskCache.swiftEntiriestoEntriesinLRUCache.swiftTest plan
swift testand verify all tests pass.🤖 Generated with Claude Code