feat: add Svelte language support#210
Open
yilanboy wants to merge 3 commits into
Open
Conversation
- update JS method pattern, including '$' - update TS method pattern, make it can catch method with generics - add Svelte language patterns and tests
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 6bbca79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Svelte language support that extends HTML and injects TypeScript.
It also includes two small JS/TS pattern changes that are technically out of scope, but were required for Svelte (and TypeScript in general) to highlight correctly. They are scoped narrowly and covered by tests.
What's in the PR
Svelte 5 language (in scope)
$state(),$derived,$effect, etc.{expression}.{#if},{:else},{/each},{@const}, etc.bind:value.Out-of-scope but necessary
JsMethodPatternallows$: Required for Svelte 5 runes ($state(),$derived(),$effect(), …). Also correct for plain JS ($()).TsMethodPattern: matchesname<Generics>(socreateList<Todo[]>(initial)highlights the method name. The existingTsGenericPatternwas consuming<…>first and leaving the method name unstyled.