INT-3427: make fixtureHook use beforeEach instead of before#464
Closed
michalnieruchalski-tiugo wants to merge 1 commit intomainfrom
Closed
INT-3427: make fixtureHook use beforeEach instead of before#464michalnieruchalski-tiugo wants to merge 1 commit intomainfrom
michalnieruchalski-tiugo wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
fixtureHookcallsTestBed.configureTestingModuleinside abeforehook, which runs once per suite. However,InitTestEnvironment.tsinitializesTestBedwithdestroyAfterEach: true, which resets the module after every test.This means the first test in any suite works fine, but every subsequent test fails because:
destroyAfterEachtears down the configured moduleTestBed.createComponent(), but the module is no longer configured providers, imports, and compiled components are gonebeforedoesn't re-run, so nothing reconfigures the moduleImpact: Only the first test in suite can run successfully. The rest fail regardless of their content. ( Assuming that succesfull module definition is required for the test to run )
Fix: Change
beforetobeforeEachinfixtureHookso thatconfigureTestingModuleruns before every test, matching the teardown lifecycle.Example. In this example only the first test will succeed, and the second one will always fail, regardless of content of these tests. If we swap the order, only the first one will succeed. It happens because providers array is always cleaned
afterEachtest.