Enable noUncheckedIndexedAccess; guard touch-event index access#60
Merged
lwwmanning merged 1 commit intomainfrom May 4, 2026
Merged
Enable noUncheckedIndexedAccess; guard touch-event index access#60lwwmanning merged 1 commit intomainfrom
lwwmanning merged 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns on TypeScript's
noUncheckedIndexedAccessintsconfig.json. Under this flag, every array/record index access has typeT | undefined, surfacing latent unsafe-index bugs across the codebase.The whole repo turns out to need only two call-site fixes, both the same pattern:
e.touches[0]inside atouchmovehandler. The browser spec doesn't strictly guaranteetouchesis non-empty duringtouchmove(some implementations fire the event with an empty list at the boundary of a touch ending), so the safest fix is to capture the touch into a local and early-return when it'sundefined:Applied identically in
src/components/hero/index.tsxandsrc/components/hero-404/index.tsx.The velite content collection (
#site/content) was the call surface I expected to be most affected, but the velite-generated types already model collection access safely, sogetAllSlugs/getPostBySlugneed no changes.Test plan
/404(the hero-404 variant uses the same touch handler)🤖 Generated with Claude Code