Auto-refactor assorted Java lint#7660
Merged
Merged
Conversation
SequencedCollections: get(0) -> getFirst(), etc Add missing @NotNull/@nullable Simplify test assertions Map operation simplification Remove redundant throws clause Switch to parameterized log message C-style array -> Java-style array declaration Delete overridden methods identical to parent Switch statement -> enhanced switch statement Remove redundant imports
This was referenced May 10, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @Override | ||
| public void write(byte b[], int off, int len) throws IOException | ||
| public void write(byte @NotNull[] b, int off, int len) throws IOException |
Contributor
Author
|
Tests are passing (BVT, Daily, External, EHR, Nightly, Nightly LKB, Nightly LKSM). Code scanning report is not new (though we should clear it separately). |
1 task
labkey-adam
approved these changes
May 12, 2026
| @@ -15,6 +15,7 @@ | |||
| <%@ page import="org.labkey.api.view.ViewServlet" %> | |||
| <%@ page import="org.labkey.api.util.URLHelper" %> | |||
| <%@ page import="java.net.URISyntaxException" %> | |||
| <%@ page import="org.jspecify.annotations.NonNull" %> | |||
| @@ -97,11 +97,11 @@ public CodeMacro() { | |||
| SourceCodeFormatter existing = formatters.get(name); | |||
| if (existing.getPriority() < formatter.getPriority()) { | |||
| formatters.put(name, formatter); | |||
| log.debug("Replacing formatter: " + formatter.getClass() + " (" + name + ")"); | |||
| log.debug("Replacing formatter: {} ({})", formatter.getClass(), name); | |||
Contributor
There was a problem hiding this comment.
Indent formatters line as well?
Contributor
Author
There was a problem hiding this comment.
Restored original indentation, which is different in Radeox than our own code. Could do a full reformat of all Radeox classes in a separate commit.
| } | ||
| } else { | ||
| formatters.put(name, formatter); | ||
| log.debug("Loaded formatter: " + formatter.getClass() + " (" + name +")"); | ||
| log.debug("Loaded formatter: {} ({})", formatter.getClass(), name); |
labkey-jeckels
added a commit
to LabKey/testAutomation
that referenced
this pull request
May 12, 2026
#### Rationale Warnings can cover up important code quality issues. #### Related Pull Requests - LabKey/platform#7660 #### Changes - SequencedCollections: `get(0)` -> `getFirst()`, etc - Add missing `@NotNull`/`@Nullable` - Simplify test assertions - Map operation simplification - Remove redundant throws clause - Switch to parameterized log message - C-style array -> Java-style array declaration - Delete overridden methods identical to parent - Switch statement -> enhanced switch statement - Remove redundant imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Warnings can cover up important code quality issues.
Changes
get(0)->getFirst(), etc@NotNull/@NullableTasks 📍
Manual TestingTest Automation