chore: disable RAB for release#16096
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request comments out the GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB macro definition in google/cloud/BUILD.bazel. The reviewer suggests removing these lines entirely rather than leaving commented-out code in the codebase. Additionally, the reviewer points out that cxxopts is not a standard Bazel attribute for cc_library and should likely be replaced with copts if the macro is intended to be functional.
| hdrs = google_cloud_cpp_rest_internal_hdrs, | ||
| # TODO(#16079): Remove macro definition when GA. | ||
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | ||
| # cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
There was a problem hiding this comment.
Avoid leaving commented-out code in the codebase as it increases technical debt and clutter. If the intention is to disable the feature for the release, the line should be removed entirely.
Furthermore, cxxopts is not a standard attribute for the cc_library rule (the standard attribute is copts), which suggests this macro definition may have been ineffective even before being commented out.
The existing TODO at line 240 already suggests removing the macro definition, so deleting the line is consistent with that goal.
| srcs = [test], | ||
| # TODO(#16079): Remove macro definition when GA. | ||
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | ||
| # cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
There was a problem hiding this comment.
Avoid leaving commented-out code in the codebase. It is better to remove the line entirely.
As noted elsewhere, cxxopts should likely be copts if this macro is intended to be used in the future. The existing TODO at line 278 also supports removing the definition.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16096 +/- ##
==========================================
- Coverage 92.70% 92.68% -0.02%
==========================================
Files 2353 2353
Lines 218354 218328 -26
==========================================
- Hits 202428 202361 -67
- Misses 15926 15967 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Feature is not GA yet, but we need to cut a release. It will be re-enabled for testing and development post-release.