Skip to content

chore: disable RAB for release #16096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 1 commit into from
May 14, 2026
+2 −2
Merged

chore: disable RAB for release #16096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ cc_library(
srcs = google_cloud_cpp_rest_internal_srcs,
hdrs = google_cloud_cpp_rest_internal_hdrs,
# TODO(#16079): Remove macro definition when GA.
cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"],
# cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid leaving commented-out code in the codebase as it increases technical debt and clutter. If the intention is to disable the feature for the release, the line should be removed entirely.

Furthermore, cxxopts is not a standard attribute for the cc_library rule (the standard attribute is copts), which suggests this macro definition may have been ineffective even before being commented out.

The existing TODO at line 240 already suggests removing the macro definition, so deleting the line is consistent with that goal.

linkopts = select({
"@platforms//os:windows": [
"-DEFAULTLIB:bcrypt.lib",
Expand Down Expand Up @@ -276,7 +276,7 @@ cc_library(
name = test.replace("/", "_").replace(".cc", ""),
srcs = [test],
# TODO(#16079): Remove macro definition when GA.
cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"],
# cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid leaving commented-out code in the codebase. It is better to remove the line entirely.

As noted elsewhere, cxxopts should likely be copts if this macro is intended to be used in the future. The existing TODO at line 278 also supports removing the definition.

deps = [
":google_cloud_cpp_rest_internal",
"//google/cloud/testing_util:google_cloud_cpp_testing_private",
Expand Down
Loading