⚡ Bolt: [performance improvement] cache IconifyIcon lookups#39
⚡ Bolt: [performance improvement] cache IconifyIcon lookups#39sshahriazz wants to merge 1 commit into
Conversation
Adds a `Map` cache inside `client/src/components/base/IconifyIcon.tsx` to memoize the result of `getIconData()` lookup logic across renders. This stops linear checking across multiple static icon bundles. Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added an in-memory
Mapcache inclient/src/components/base/IconifyIcon.tsxto memoize the resolution of string identifiers to their respective SVG paths/data.🎯 Why: The application heavily relies on icons. For every re-render and mount, the
IconifyIconcomponent previously executediconData(), which dynamically resolved prefixes by parsing strings and performing string manipulation, nested object accesses, and occasionally iterating through allObject.entries(iconSets)linearly, usinggetIconData()on every render without caching.📊 Impact: Reduces linear iteration operations across 11 icon sets down to ~0 operations after the first render, dropping CPU overhead considerably during React diffing and updates.
🔬 Measurement: Inspect standard client-side trace profiles in the React DevTools Profiler while typing in inputs or changing panels that hold icons. Re-renders will execute
O(1)Map lookup intercept instead of executing standard array destructurings andiconify/utilschecks.PR created automatically by Jules for task 1462047439991688958 started by @sshahriazz