Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-02-12 - IconifyIcon Lookups Uncached
**Learning:** `client/src/components/base/IconifyIcon.tsx` resolves icons statically from multiple imported `@iconify-json` bundles but performs a linear lookup with `getIconData()` on every render without caching.
**Action:** Add a simple `Map` cache inside `IconifyIcon.tsx` to memoize the result of `getIconData()` across renders.
19 changes: 17 additions & 2 deletions client/src/components/base/IconifyIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,33 @@ const iconSets: Record<string, IconifyJSON> = {
"mdi-light": mdiLightIcons,
};

import { IconifyIcon as IconifyIconType } from "@iconify/react";

const iconCache = new Map<string, IconifyIconType | undefined>();

const iconData = (icon: string) => {
if (iconCache.has(icon)) return iconCache.get(icon);

const [prefix, name] = icon.includes(":") ? icon.split(":") : ["", icon];

if (prefix && iconSets[prefix]) {
const data = getIconData(iconSets[prefix], name);
if (data) return data;
if (data) {
iconCache.set(icon, data);
return data;
}
}

for (const [_, icons] of Object.entries(iconSets)) {
const data = getIconData(icons, name);
if (data) return data;
if (data) {
iconCache.set(icon, data);
return data;
}
}

iconCache.set(icon, undefined);
return undefined;
};

const IconifyIcon = ({
Expand Down