fix(workloadapi): refresh cached JWT SVIDs without iat#430
Open
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Open
fix(workloadapi): refresh cached JWT SVIDs without iat#430maxlambrecht wants to merge 1 commit intospiffe:mainfrom
maxlambrecht wants to merge 1 commit intospiffe:mainfrom
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
fix/cached-jwt-svid-missing-iat
branch
from
b606c56 to
81c9d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
CachedJwtSourceso cached JWT SVIDs without aniatclaim are treated as needing refresh instead of computing half-life from a missing issued-at value.Add a regression test that seeds the cache with a JWT SVID containing
subandexpbut noiat, then verifies the cache path does not throwNullPointerException.Why
JwtSvidparsing currently allows JWT SVIDs withoutiat, butCachedJwtSource.isTokenPastHalfLifetimeassumedgetIssuedAt()was always available. That could crash cache reuse with aNullPointerException.The fix keeps JWT SVID validation behavior unchanged and makes only the cache behavior more conservative.
How tested
Ran:
./gradlew :java-spiffe-core:test --tests io.spiffe.workloadapi.CachedJwtSourceTest --tests io.spiffe.workloadapi.DefaultJwtSourceTest